Related Pages Bug

Post any bugs, problems or feature requests here.
Mercury
Mercury Salia
Brend
Brend

Related Pages Bug

Post Mercury » Thu Jan 17, 2013 9:31 pm
User avatar
Mercury
Storyteller
 
I discovered a very peculiar Related Pages Bug that seems to be caused by the number 7

viewtopic.php?f=3&t=7

More specifically, it appears as if there is an ilike match on the topic number rather than an exact match: if the topic number is a substring of one or more related topics listed in the story page, it appears as a related page, even appearing multiple times if this is the case for multiple entries.

I believe this could be fixed by requiring an exact numerical match.

Also, I noticed the sorting order is random. If you load a page several times (but not when you reload for some reason), the order in which related threads are listed is random, probably due to there being no sorting order for the query. I guess that is not a big issue, but perhaps they should be sorted chronologically by topic age (which is as simple as sorting by full topic number).
Post Brend » Fri Jan 18, 2013 1:00 am
User avatar
Brend
 
Hehe, yes. This is an unexpected side-effect of the way references to single posts are handled. I will look into fixing this tomorrow.

As to the sorting. Would you care to explain what you try to say? The forum does not have 'related threads' (by the by, the forum calls them 'topics' everywhere -- so I have started to do the same in the whole user interface to have a more coherent site), and the wiki pages can not be easily sorted in chronological order. 'topic age' doesn't really come into play with the related pages feature, so please elaborate ^_^
Post Brend » Fri Jan 18, 2013 11:19 pm
User avatar
Brend
 
Ok. The prefix match bug is fixed.

After a thorough reread, I still don't get what you want to say on the second issue. Could you elaborate?
Post Mercury » Fri Jan 18, 2013 11:45 pm
User avatar
Mercury
Storyteller
 
Thanks for fixing this bug!

To elaborate: if a thread is connected to more than one storyline (as was the case in the example due to the bug), it displays multiple related wiki pages.

Currently, that list is unordered - in other words, the order in which the connected storylines are listed in the list of related pages depends on the order the database happens to pulls them out of its ass (which is essentially random).

That means that one time I get them in one order, but another time in another order. Note this does not happen every time, but only after a while (there may be server side caching) for maximum inconvenience.
Post Brend » Fri Jan 18, 2013 11:46 pm
User avatar
Brend
 
I could sort them, but there is no reasonable way to order them chronologically, and you specifically asked for that with "they should be sorted chronologically by topic age (which is as simple as sorting by full topic number)"... Which is completely dropped from your elaboration it seems O_o

Will wait for reply before adding sorting.
Post Mercury » Fri Jan 18, 2013 11:55 pm
User avatar
Mercury
Storyteller
 
I was inverting reality. Now that its no longer inverted, my solution no longer works. Course Salia claims we're all inverted, so there's that.
Post Salia » Fri Jan 18, 2013 11:57 pm
User avatar
Salia
PC
 
"Whee!"
Post Brend » Sat Jan 19, 2013 12:00 am
User avatar
Brend
 
O_o

From this, I take it that your brain was broken when writing that stuff about topics...

I will implement the sorting.
Post Mercury » Sat Jan 19, 2013 12:12 am
User avatar
Mercury
Storyteller
 
Why are you speaking in the past tense? :P
Post Brend » Sun Jan 20, 2013 2:06 am
User avatar
Brend
 
Ok. The related pages are now sorted in alphabetical order (in the page titles).

Return to Technical

cron